Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 'downsample' constants (#1721) #1923

Merged
merged 1 commit into from
Mar 11, 2020
Merged

Remove 'downsample' constants (#1721) #1923

merged 1 commit into from
Mar 11, 2020

Conversation

lutzroeder
Copy link
Contributor

Fixes #1721:

~/pytorch/lib/python3.7/site-packages/torch/jit/_recursive.py:146: UserWarning: 'downsample' was found in ScriptModule constants, but it is a non-constant submodule. Consider removing it. " but it is a non-constant {}. Consider removing it.".format(name, hint))

@fmassa @eellison #1727 #1907

fmassa
fmassa approved these changes Mar 11, 2020
View reviewed changes
Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, and sorry for the delay in reviewing!

@fmassa fmassa merged commit b70e333 into pytorch:master Mar 11, 2020
fmassa pushed a commit to fmassa/vision-1 that referenced this pull request Jul 8, 2020
@lutzroeder @fmassa
Remove 'downsample' constants (pytorch#1721) (pytorch#1923)
2ff8f66
facebook-github-bot pushed a commit that referenced this pull request Jul 8, 2020
@lutzroeder @facebook-github-bot
Remove 'downsample' constants (#1721) (#1923) (#2419)
2eddf2a 
Summary: Pull Request resolved: #2419

Reviewed By: zhangguanheng66

Differential Revision: D22432605

Pulled By: fmassa

fbshipit-source-id: f677348d87fb7ee852d158222387313fd26d5dc3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmassa fmassa fmassa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UserWarning: 'layers' was found in ScriptModule constants
2 participants
@lutzroeder @fmassa