add comments for the modified implementation of ResNet #1983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmassa
pushed a commit
to fmassa/vision-1
that referenced
this pull request
Jul 8, 2020
Co-authored-by: Charles Pao <dirtybluer@gmail.com>
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 8, 2020
Summary: Pull Request resolved: #2424 Reviewed By: zhangguanheng66 Differential Revision: D22432635 Pulled By: fmassa fbshipit-source-id: 16fa637f14c4bac61f3705ec2c742a0d9e713596 Co-authored-by: Charles Pao <dirtybluer@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reference to #191 added comments to clarify the differences between torchvision's implementation of ResNet and the one in original paper.
Not sure if it's the proper place to insert such comments and if I have explained the situation clear enough.
Please let me know if further modifications are needed. @fmassa