Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default training parameters to classification refrence README #1998

Merged
merged 2 commits into from
Mar 20, 2020
Merged

Add default training parameters to classification refrence README #1998

merged 2 commits into from
Mar 20, 2020

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Mar 20, 2020

Addresses #1986 (comment).

@pmeier pmeier changed the title Add default training parameters to classification refrence Add default training parameters to classification refrence README Mar 20, 2020
fmassa
fmassa reviewed Mar 20, 2020
View reviewed changes
Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR Philip!

I have one minor comment, otherwise looks good to merge!

references/classification/README.md Outdated Show resolved Hide resolved
fmassa
fmassa approved these changes Mar 20, 2020
View reviewed changes
Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks a lot!

@fmassa fmassa merged commit ae228fe into pytorch:master Mar 20, 2020
@pmeier pmeier deleted the classification_reference_params branch March 20, 2020 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmassa fmassa fmassa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pmeier @fmassa