Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F.normalize unsqueeze mean & std only for 1-d arrays #2002

Merged
merged 2 commits into from
Mar 23, 2020

Conversation

dizcza
Copy link
Contributor

@dizcza dizcza commented Mar 20, 2020

I use a normalizer with 3d mean and std: per channel per pixel.
I've been using it for 2 years and thought that eventually, someone will come to this idea as well.
Well, seems like nobody wanted this feature so far, and I'm curious why.

If you think it does not make sense, please explain.

Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! This is something I wanted to do for some time already!

Can you add some tests for this functionality? Once tests are added this is good to merge

Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@fmassa fmassa merged commit e61b68e into pytorch:master Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants