Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add return statement #2029

Merged
merged 1 commit into from
Mar 30, 2020
Merged

Add return statement #2029

merged 1 commit into from
Mar 30, 2020

Conversation

PatrickBue
Copy link
Contributor

Adding simple 'return' statement to the train_one_epoch() function.

Fyi, we (Microsoft) are using the references/detection folder as-is in our Computer Vision Best Practices repository. All our Jupyter notebooks and higher-level functionality for Object Detection is based fully on torchvision.

See these notebooks:
https://github.com/microsoft/computervision-recipes/tree/master/scenarios/detection

And Torchvision's reference folder is copy & pasted here:
https://github.com/microsoft/computervision-recipes/tree/master/utils_cv/detection/references

Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

Great to know that torchvision is being helpful for providing those reference implementations!

Would love to hear any feedback you might have!

@fmassa fmassa merged commit 1c7aa0c into pytorch:master Mar 30, 2020
@PatrickBue
Copy link
Contributor Author

@fmassa Thanks for the quick sign-off!

More of a general question: a lot of the notebooks we implemented I believe would be very helpful for somebody who wants to use Torchvision for object detection. For example:

Currently, the references folder lacks a bit with regards to e.g. explanations or being beginner-friendly. Is there anywhere on Torchvision with links to resources such as our repo? Possible options could maybe be:

fmassa pushed a commit to fmassa/vision-1 that referenced this pull request Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants