Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove python2 compability code #2033

Merged
merged 3 commits into from
Mar 31, 2020
Merged

Remove python2 compability code #2033

merged 3 commits into from
Mar 31, 2020

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Mar 31, 2020 •
edited
Loading

Addresses #2017 (comment)

@pmeier
Copy link
Collaborator Author

pmeier commented Mar 31, 2020

What is the minimal Python3 version that we will support? Found a few blocks like this one

vision/torchvision/transforms/functional.py

Lines 16 to 21 in 7ee5a8b

if sys.version_info < (3, 3):
Sequence = collections.Sequence
Iterable = collections.Iterable
else:
Sequence = collections.abc.Sequence
Iterable = collections.abc.Iterable

fmassa
fmassa approved these changes Mar 31, 2020
View reviewed changes
Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@fmassa fmassa merged commit 24f16a3 into pytorch:master Mar 31, 2020
@fmassa
Copy link
Member

fmassa commented Mar 31, 2020

What is the minimal Python3 version that we will support?

Minimum supported Python version is 3.5, so we can drop support for cases < 3.5

@pmeier pmeier deleted the remove_py2_dependency branch March 31, 2020 18:42
@pmeier pmeier mentioned this pull request Apr 1, 2020
Merged
fmassa pushed a commit to fmassa/vision-1 that referenced this pull request Jul 8, 2020
@pmeier @fmassa
Remove python2 compability code (pytorch#2033)
31fdf4c 
* remove sys.version_info == 2

* remove sys.version_info < 3

* remove from __future__ imports
facebook-github-bot pushed a commit that referenced this pull request Jul 9, 2020
@fmassa @facebook-github-bot
Remove python2 compability code (#2033) (#2434)
f487ab4 
Summary:
* remove sys.version_info == 2

* remove sys.version_info < 3

* remove from __future__ imports

Pull Request resolved: #2434

Reviewed By: zhangguanheng66

Differential Revision: D22438377

Pulled By: fmassa

fbshipit-source-id: 89ce27cd2f1bfbff7448a92831ead320784f0b88
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmassa fmassa fmassa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pmeier @fmassa