Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove mock #2096

Merged
merged 1 commit into from
Apr 14, 2020
Merged

Remove mock #2096

merged 1 commit into from
Apr 14, 2020

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Apr 12, 2020 •
edited
Loading

This removes the dependency on mock package since

mock is now part of the Python standard library, available as unittest.mock in Python 3.3 onwards.

pmeier
pmeier commented Apr 12, 2020
View reviewed changes
test/test_transforms.py
@@ -1,5 +1,4 @@
import os
import mock
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was unused here and thus it is simply removed and not replaced.

@pmeier
Copy link
Collaborator Author

pmeier commented Apr 12, 2020

@fmassa Test failure seems unrelated.

fmassa
fmassa approved these changes Apr 14, 2020
View reviewed changes
Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Philip!

@fmassa fmassa merged commit ad4daec into pytorch:master Apr 14, 2020
@pmeier pmeier deleted the remove_mock branch July 30, 2020 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmassa fmassa fmassa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pmeier @fmassa