packaging: Add BUILD_VERSION as a script_env to pass #2137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BUILD_VERSION was not getting propagated properly through our conda packaging, which made release builds look as though they were actually develpoment builds. This remedies that by having conda pass the environment variable BUILD_VERSION through to the "python setup.py install" portion of the "conda build". This might have some side effects but I think overall this should be a fairly harmless change. Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
|
Thanks Eli! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUILD_VERSION was not getting propagated properly through our conda
packaging, which made release builds look as though they were actually
develpoment builds.
This remedies that by having conda pass the environment variable
BUILD_VERSION through to the "python setup.py install" portion of the
"conda build".
This might have some side effects but I think overall this should be a
fairly harmless change.
closes #2133
Signed-off-by: Eli Uriegas eliuriegas@fb.com