-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add all the latest models to hubconf #2189
Conversation
I think it makes sense to publish those models. @fmassa any ideas? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
The MNasNet models seems good, but I think we might have issues with the detection models.
cc @ailzhang do we already support compiled extensions in Hub?
hubconf.py
Outdated
from torchvision.models.detection import fasterrcnn_resnet50_fpn, \ | ||
maskrcnn_resnet50_fpn, keypointrcnn_resnet50_fpn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think detection models won't work as expected with torchhub.
This is because they require compiled C++ extensions, which do not get compiled in Hub, and would instead try to pick the ops from torchvision.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will remove detection models. Segmentation models are okay?
which do not get compiled in Hub, and would instead try to pick the ops from torchvision.
Ah why they worked on my local env.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because you already have torchvision installed on your system. But if the version of torchvision that you had installed in your system was quite old (say 0.3.0), then the model wouldn't work because the interface for the custom ops has since changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
New models in torchvison are not in hub yet.