Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all the latest models to hubconf #2189

Merged
merged 3 commits into from
May 11, 2020
Merged

Conversation

chsasank
Copy link
Contributor

@chsasank chsasank commented May 6, 2020

New models in torchvison are not in hub yet.

@zhangguanheng66
Copy link
Contributor

I think it makes sense to publish those models. @fmassa any ideas?

Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

The MNasNet models seems good, but I think we might have issues with the detection models.

cc @ailzhang do we already support compiled extensions in Hub?

hubconf.py Outdated
Comment on lines 23 to 24
from torchvision.models.detection import fasterrcnn_resnet50_fpn, \
maskrcnn_resnet50_fpn, keypointrcnn_resnet50_fpn
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think detection models won't work as expected with torchhub.
This is because they require compiled C++ extensions, which do not get compiled in Hub, and would instead try to pick the ops from torchvision.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will remove detection models. Segmentation models are okay?

which do not get compiled in Hub, and would instead try to pick the ops from torchvision.

Ah why they worked on my local env.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because you already have torchvision installed on your system. But if the version of torchvision that you had installed in your system was quite old (say 0.3.0), then the model wouldn't work because the interface for the custom ops has since changed.

Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fmassa fmassa merged commit caf15cd into pytorch:master May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants