Add static type check with mypy #2195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmeier
commented
May 8, 2020
| flake8 . | ||
| flake8 --config=setup.cfg . |
There was a problem hiding this comment.
Without setting this explicitly flake8 seems to ignore the config altogether. For an example see
setup.cfg specifies to ignore F821, but it still errors with it.
fmassa
approved these changes
May 11, 2020
| @@ -9,5 +9,5 @@ max-line-length = 120 | |||
|
|
|||
| [flake8] | |||
| max-line-length = 120 | |||
| ignore = F401,E402,F403,W503,W504 | |||
| ignore = F401,E402,F403,W503,W504,F821 | |||
There was a problem hiding this comment.
Interesting, in the future we might want to remove this F821 and instead fix the annotations
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now
mypyis configured to ignore every sub-package oftorchvision. This restriction should be lifted PR by PR.@fmassa This also fixes one remaining syntax error not covered by #1696 as well as some errors that were missed in #2034. I've included them here to have clean CI build, but I can split them off in separate PRs if you want.