Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Restored support of tuple of Tensors for region pooling ops #2199

Merged
merged 6 commits into from
May 11, 2020
Merged

fix: Restored support of tuple of Tensors for region pooling ops #2199

merged 6 commits into from
May 11, 2020

Conversation

frgfm
Copy link
Contributor

@frgfm frgfm commented May 11, 2020

This PR addresses #2197 by:

  • adding support of tuple of Tensors in check_roi_boxes_shape
  • testing the box conversions on the different tensor sequence types

@frgfm frgfm mentioned this pull request May 11, 2020
Closed
fmassa
fmassa approved these changes May 11, 2020
View reviewed changes
Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

fmassa
fmassa requested changes May 11, 2020
View reviewed changes
Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failures seem related though

@frgfm
Copy link
Contributor Author

frgfm commented May 11, 2020

Any clue why travis is throwing errors about nms @fmassa?
Either it's unrelated to this PR or I have no clue where it comes from

@frgfm frgfm requested a review from fmassa May 11, 2020 14:19
fmassa
fmassa approved these changes May 11, 2020
View reviewed changes
Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

NMS failures are unrelated

@fmassa fmassa merged commit a09d129 into pytorch:master May 11, 2020
@frgfm frgfm deleted the roi-pool-support branch May 11, 2020 14:50
fmassa pushed a commit to fmassa/vision-1 that referenced this pull request Jul 10, 2020
@frgfm @fmassa
fix: Restored support of tuple of Tensors for region pooling ops (pyt…
034f007 
…orch#2199)

* feat: Restored support of tuple of Tensors for roi_align & roi_pool

* test: Added unittest for Tensor sequence support by region pooling

* test: Fixed typo in unittest

* test: Fixed data type

* test: Fixed roi pooling tensor unittest

* test: Fixed box format conversion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmassa fmassa fmassa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frgfm @fmassa