-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove script annotations / eager compilation #2210
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once tests pass, thanks a lot @eellison !
@eellison test failures seems related, could you have a look? |
3f3419e
to
7dbfeaf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lint failures are unrelated and have been fixed in master. Thanks a lot Elias!
Co-authored-by: eellison <eellison@fb.com>
It's unfortunate that this wasn't included in 0.6.1. Since future releases will apparently only support Python 3.6+, if you just run I don't suppose there's a 0.6.2 planned? |
@IRDonch There isn't, but we are going to be releasing 0.7.0 in the next few weeks (but no Python 3.5 support) |
Also, @IRDonch note that this is only broken for torchhub models, the rest of torchvision should not be broken for the 0.6.1 release on Python 3.5 |
Just importing |
@IRDonch are you using virtualenv? It had some bad interactions with |
After pytorch/pytorch#38050, classes compile recursively so there is no longer any need to annotation them. And we can use
_script_if_tracing
to not eagerly compile the script functions but still compile them when we trace.I'm hoping this resolves #2132
Edit looks like #38050 hasnt made its way to nightly yet