vision classification QAT tutorial: fix for DDP (redo) #2230
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Redo of #2191
Makes the classification QAT tutorial not crash when used
with DDP. There were two issues:
are created on CPU. In the context of this repo, the fix is to finalize
the model before moving to GPU. We can potentially follow up with a
better error message in the future, in a separate PR.
problems. The fix is to unwrap the model from DDP before cloning it for
evaluation.
There is still work to do on verifying that BN is working correctly in
QAT + DDP, but saving that for a separate PR.
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags: