Feature/layer freezing maskrcnn keypointrcnn #2242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmassa
reviewed
May 20, 2020
There was a problem hiding this comment.
Changes look good to me, thanks a lot @muaz-urwa !
There seems to be some python lint failures, can you fix those? Here are the errors https://circleci.com/gh/pytorch/vision/142749?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link:
./test/test_models_detection_utils.py:37:1: W293 blank line contains whitespace
./test/test_models_detection_utils.py:46:45: E127 continuation line over-indented for visual indent
./test/test_models_detection_utils.py:47:45: E127 continuation line over-indented for visual indent
./test/test_models_detection_utils.py:61:45: E128 continuation line under-indented for visual indent
./test/test_models_detection_utils.py:62:45: E128 continuation line under-indented for visual indent
./torchvision/models/detection/mask_rcnn.py:318:37: E225 missing whitespace around operator
./torchvision/models/detection/mask_rcnn.py:318:73: E225 missing whitespace around operator
./torchvision/models/detection/keypoint_rcnn.py:322:37: E225 missing whitespace around operator
./torchvision/models/detection/keypoint_rcnn.py:322:73: E225 missing whitespace around operator
|
@fmassa my bad. I have corrected the linting errors but some checks are still failing. I have checked the logs, these changes don't appear to be the reason. Will be happy to look deeper if you think otherwise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is a follow up pull reguest to PR, as requested by @fmassa .
This PR adds arguments to keypointrcnn_resnet50_fpn and maskrcnn_resnet50_fpn functions, which allow the user to control the number of frozen layers in the backbone. Visit the previous PR (link above) to learn more about it.
I have also added respective test cases.
Let me know if any changes are required.