Reuse common logic and migrate CUDA >= 10.1 jobs to VS 2019 for Windo… #2264
Conversation
peterjc123
force-pushed
the
migrate_vs2019
branch
from
0eee791 to
6e2a07a
Compare
|
@fmassa Hi, with this code refactor PR, I think it will be better to split out the unit test so that they don't run in binary jobs. And also we should migrate the unit test jobs to CircleCI. This is already done in pytorch/audio and pytorch/text. What do you think? |
| steps: | ||
| - checkout_merge | ||
| - run: | ||
| command: | | ||
| choco install miniconda3 | ||
| (& "C:\tools\miniconda3\Scripts\conda.exe" "shell.powershell" "hook") | Out-String | Invoke-Expression | ||
| set -ex |
There was a problem hiding this comment.
This might be a follow up PR but it'd be nice if this logic was just captured in a re-usable command or a script so that we don't have to copy / paste it everywhere
There was a problem hiding this comment.
Sounds reasonable. Will fix.
packaging/build_wheel.bat
Outdated
| set VC_VERSION_UPPER=16 | ||
| ) | ||
|
|
||
| for /f "usebackq tokens=*" %%i in (`"%ProgramFiles(x86)%\Microsoft Visual Studio\Installer\vswhere.exe" -legacy -products * -version [%VC_VERSION_LOWER%^,%VC_VERSION_UPPER%^) -property installationPath`) do ( |
There was a problem hiding this comment.
Is it possible to condense this as an extra step in the circleci config that runs only on windows wheel builds?
Seems like it'd be better to do that instead of having it completely shell out to a separate script.
There was a problem hiding this comment.
It is not easy to share an environment between Bash and CMD, especially when you want to activate the env in CMD and get the env back in Bash.
There was a problem hiding this comment.
Actually, I come up with an idea that we could create a utility to activate the env and do sth in CMD by passing arguments.
peterjc123
force-pushed
the
migrate_vs2019
branch
from
6782ea8 to
dedcd6b
Compare
peterjc123
force-pushed
the
migrate_vs2019
branch
from
dedcd6b to
3d470bb
Compare
|
@seemethere Comments fixed. |
Yes, this is something that would be great to do. I did it as is for Linux / OSX because it was the simplest way to get things working, but it should be separated ideally. |
|
Interesting why the windows builds are failng, perhaps it's due to the fact that the windows conda uploads have been broken upstream? |
|
@seemethere Yes, the upstream pytorch binary jobs are failing. Have to wait for the upstream nightly conda packages to be uploaded. |
|
Other conda CUDA versions have passed, I'm comfortable merging this as is. |
The MS folks @nbcsm @guyang3532 are working on this. |
…ws jobs