[BC-breaking] RandomErasing is now scriptable #2386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- RandomErasing is not scriptable
Codecov Report
@@ Coverage Diff @@
## master #2386 +/- ##
==========================================
- Coverage 70.76% 70.72% -0.04%
==========================================
Files 93 94 +1
Lines 7788 7870 +82
Branches 1209 1238 +29
==========================================
+ Hits 5511 5566 +55
- Misses 1913 1930 +17
- Partials 364 374 +10
Continue to review full report at Codecov.
|
vfdev-5
changed the title
- added additional checking of value vs img num_channels
16 tasks
de-vri-es
pushed a commit
to fizyr-forks/torchvision
that referenced
this pull request
Aug 4, 2020
* Related to pytorch#2292 - RandomErasing is not scriptable * Fixed code according to review comments - added additional checking of value vs img num_channels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2292
Description
This PR changes the default behavior of
get_paramsfunction, as beforevalue=0and nowvalue=Nonewhich is interpreted as Gaussian random noise. If users are callingget_paramsexplicitly this would be a BC-breaking change.