Unified inputs for T.RandomAffine transformation (2292)
#2478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 tasks
Codecov Report
@@ Coverage Diff @@
## master #2478 +/- ##
==========================================
+ Coverage 68.82% 71.46% +2.64%
==========================================
Files 94 94
Lines 7974 8320 +346
Branches 1267 1420 +153
==========================================
+ Hits 5488 5946 +458
+ Misses 2082 1947 -135
- Partials 404 427 +23
Continue to review full report at Codecov.
|
fmassa
approved these changes
Jul 29, 2020
| @@ -734,14 +733,14 @@ def __init__(self, size, scale=(0.08, 1.0), ratio=(3. / 4., 4. / 3.), interpolat | |||
|
|
|||
| @staticmethod | |||
| def get_params( | |||
| img: Tensor, scale: Tuple[float, float], ratio: Tuple[float, float] | |||
| img: Tensor, scale: List[float], ratio: List[float] | |||
There was a problem hiding this comment.
The changes in this function seem unrelated to the whole goal of the PR.
For the next time, can you please factor them out in a different PR?
bryant1410
pushed a commit
to bryant1410/vision-1
that referenced
this pull request
Nov 22, 2020
* [WIP] Unified input for T.RandomAffine * Unified inputs for T.RandomAffine transformation * Update transforms.py * Updated docs of F.affine fillcolor * Update transforms.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2292
Description:
T.RandomAffinetransformationAdditionally:
RandomResizedCropto accept both types tuples and lists (scripted and non-scripted versions)