Fixed resize to only match the smaller edge when an int is given #2518
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2518 +/- ##
==========================================
+ Coverage 70.65% 70.67% +0.02%
==========================================
Files 94 94
Lines 8007 8007
Branches 1278 1278
==========================================
+ Hits 5657 5659 +2
+ Misses 1945 1944 -1
+ Partials 405 404 -1
Continue to review full report at Codecov.
|
|
Hi @pmeier! Thanks for the review. I added a test that I believe will lead to different results between the PIL resize and the tensor resize (with the old code) but I have not run the tests locally to confirm. |
| if (w <= h and w == size_w) or (h <= w and h == size_h): | ||
| return img |
There was a problem hiding this comment.
@vfdev-5 Could you explain what your intention for this guarding clause was? Is this just to detect the case if no resizing needs to happen? If yes, why not simply do
if (w,h) == (size_w, size_h):
return There was a problem hiding this comment.
I think the intention is that (according to the function docstring), if only one number is given as size, we resize to match the smaller dimension to that number. The check there is for the case when the smaller dimension matches the number given and no resizing needs to happen. But it doesn't mean that both dims need to match
There was a problem hiding this comment.
Sorry for delayed reply! Yes, this function should mimic PIL implementation : https://github.com/pytorch/vision/blob/master/torchvision/transforms/functional_pil.py#L324 where definitely this condition is applied in case when if isinstance(size, int) or len(size) == 1. Thanks for the fix @ag14774 !
…orch#2518) * Fixed resize to only match the smaller edge when an int is given instead of always * Added test cases for resize()
The smaller edge should be matched and the aspect ratio should be kept the same only when one int or a list of one element is given. When an explicit tuple of (h,w) is given, the image should always be resized to the requested size
This fixes #2517