Use include_directories, to help packaging of C++. #2587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmanga
approved these changes
Aug 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR helps packaging the C++ library of torchvision, making its build non dependent of the machine that packaged the library.
The problem is due to the usage of
INTERFACE_INCLUDE_DIRECTORIESin the CMakeLists file, since it is not advisable to populate theINSTALL_INTERFACEof theINTERFACE_INCLUDE_DIRECTORIESof a target with paths for dependencies. That would hard-code into installed packages the include directory paths for dependencies as found on the machine the package was made on [source].Follow up of pull request:
#2446