Refactor adjust ops tests #2595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-5/issue-2292-unify-grayscale
…-6/issue-2292-unify-grayscale
- deprecated F.to_grayscale in favor of F.rgb_to_grayscale
- split test_adjustments into 3 separate tests - unified testing approach with test_adjust_gamma
Codecov Report
@@ Coverage Diff @@
## master #2595 +/- ##
==========================================
+ Coverage 70.34% 71.68% +1.34%
==========================================
Files 95 94 -1
Lines 8245 8162 -83
Branches 1308 1298 -10
==========================================
+ Hits 5800 5851 +51
+ Misses 2022 1901 -121
+ Partials 423 410 -13
Continue to review full report at Codecov.
|
…-5/rewrite-test-adjust-ops
bryant1410
pushed a commit
to bryant1410/vision-1
that referenced
this pull request
Nov 22, 2020
* [WIP] Unify ops Grayscale and RandomGrayscale * Unified inputs for grayscale op and transforms - deprecated F.to_grayscale in favor of F.rgb_to_grayscale * Fixes bug with fp input * Rewritten adjust_* tests - split test_adjustments into 3 separate tests - unified testing approach with test_adjust_gamma * Added ColorJitter tests * Relaxed tolerance for functional adjust-* tests * Removed wrong merge and commented code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Currently
test_adjustmentstest mixes functional and transform tests for 3 color ops:adjust_brightness,adjust_contrastandadjust_saturation.This PR solves the following problems:
Notes: