Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped version to v0.7.0 and removed a commented line #2626

Merged
merged 1 commit into from
Aug 28, 2020

Conversation

vfdev-5
Copy link
Collaborator

@vfdev-5 vfdev-5 commented Aug 28, 2020

Description:

  • Minor update of CMakeLists.txt

Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fmassa fmassa merged commit 10d5a55 into pytorch:master Aug 28, 2020
@fmassa
Copy link
Member

fmassa commented Aug 28, 2020

One comment about this though is that master version of torchvision is now at 0.8.0

@vfdev-5
Copy link
Collaborator Author

vfdev-5 commented Aug 28, 2020

@fmassa correct. I think it would be better to find out a way to fetch the version from setup.py. What do you think ?

@vfdev-5 vfdev-5 deleted the updated-cmakelists branch August 28, 2020 09:33
@fmassa
Copy link
Member

fmassa commented Aug 28, 2020

I think we are moving towards using CMake inside setup.py, so that might come naturally.

bryant1410 pushed a commit to bryant1410/vision-1 that referenced this pull request Nov 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants