Improved functional tensor geom transforms to work on floatX dtype #2661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes pytorch#2600 - added tests - refactored test_affine
…-5/issue-2600-support-floatX-types
Codecov Report
@@ Coverage Diff @@
## master #2661 +/- ##
==========================================
- Coverage 72.41% 72.15% -0.27%
==========================================
Files 95 95
Lines 8245 8379 +134
Branches 1308 1365 +57
==========================================
+ Hits 5971 6046 +75
- Misses 1858 1921 +63
+ Partials 416 412 -4
Continue to review full report at Codecov.
|
fmassa
reviewed
Sep 14, 2020
…-2600-support-floatX-types
…Quansight/vision into vfdev-5/issue-2600-support-floatX-types
fmassa
approved these changes
Sep 14, 2020
bryant1410
pushed a commit
to bryant1410/vision-1
that referenced
this pull request
Nov 22, 2020
…ytorch#2661) * Improved functional tensor geom transforms to work on floatX dtype - Fixes pytorch#2600 - added tests - refactored test_affine * Removed float16/cpu case
vfdev-5
added a commit
to Quansight/vision
that referenced
this pull request
Dec 4, 2020
…ytorch#2661) * Improved functional tensor geom transforms to work on floatX dtype - Fixes pytorch#2600 - added tests - refactored test_affine * Removed float16/cpu case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2600
Description:
Improved functional tensor geom transforms to work on floatX dtype