fix scheduled download tests #2706
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2706 +/- ##
=======================================
Coverage 72.87% 72.87%
=======================================
Files 95 95
Lines 8237 8237
Branches 1285 1285
=======================================
Hits 6003 6003
Misses 1839 1839
Partials 395 395 Continue to review full report at Codecov.
|
pmeier
changed the title
| return dict(argnames="url, md5", argvalues=argvalues, ids=ids) | ||
|
|
||
|
|
||
| def places365(): |
There was a problem hiding this comment.
To add new download tests for a dataset, simply implement a similar function and add it to L130 and optionally to L135.
|
As reported in JasonEtco/create-an-issue#65 (comment) this issue most likely does not lie in the action itself, but rather in a dependency. Thus, the fix is probably going to take a while and I've implemented a workaround. This means that the automatically created issue will not be labeled |
|
After some further inspection the issue does not lie with https://github.com/JasonEtco/create-an-issue, but rather with our repository configuration. I suspect the GitHub Actions bot has no permission to open the issue. As a workaround, I'm disabling the issue generation for now and re-enable it as soon as this is resolved. IMO we should merge this now to at least have the test although their success / failure has to be checked manually. Since I'm not able to debug this any further myself, I can't tell how long it takes until this will be completely resolved. |
|
@fmassa Test failure is unrelated. |
|
#2714 showed that the issue creation works as expected when performed from a scheduled workflow. Thus, the last commit re-enables it. |
* fix triggers for scheduled workflow * more fix * add missing repository checkout * try fix label in template * rewrite test infrastructure * trigger issue generation * try fix issue template * try remove quotes * remove buggy label * try fix title * cleanup * add more test details * reenable issue creation Co-authored-by: Francisco Massa <fvsmassa@gmail.com>
* fix triggers for scheduled workflow * more fix * add missing repository checkout * try fix label in template * rewrite test infrastructure * trigger issue generation * try fix issue template * try remove quotes * remove buggy label * try fix title * cleanup * add more test details * reenable issue creation Co-authored-by: Francisco Massa <fvsmassa@gmail.com>
I've messed up the syntax for the workflow triggers in #2675. Thus, the CI does not even spin up. I think, it uses
pushas a default trigger, which is why we see some failed runs.Edit: Unfortunately, I need to fix two more things:
The issue generation is bugged for labels including a colon such asmodule: datasets. I've opened and issue. Depending on the response speed of the maintainer we either need to simply upgrade the action version or remove the label.