Add decode_image op #2718
Merged
Add decode_image op #2718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2718 +/- ##
==========================================
+ Coverage 72.87% 72.91% +0.03%
==========================================
Files 95 95
Lines 8237 8233 -4
Branches 1285 1279 -6
==========================================
Hits 6003 6003
+ Misses 1839 1838 -1
+ Partials 395 392 -3
Continue to review full report at Codecov.
|
bryant1410
pushed a commit
to bryant1410/vision-1
that referenced
this pull request
Nov 22, 2020
* Add decode_image op * Fix lint * More lint * Add C10_EXPORT
vfdev-5
pushed a commit
to Quansight/vision
that referenced
this pull request
Dec 4, 2020
* Add decode_image op * Fix lint * More lint * Add C10_EXPORT
|
Hello. Thanks for adding this functionality. Just a quick question: would there be any plan for a GPU implementation for this op? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2686
For a follow-up PR, I'm thinking about removing
read_jpeg/read_png(and potentiallyread_image) because they are now just wrappers around_read_file+decode*. I'll also move_read_fileto C++, so that all ops can be torchscriptable.The implementation in
read_image_cpu.cppcan definitely be improved, but this is just a first version to get things moving forward.