-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docstings and expose main image io functions in the vision docs #2760
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2760 +/- ##
=======================================
Coverage 73.09% 73.09%
=======================================
Files 96 96
Lines 8321 8322 +1
Branches 1295 1295
=======================================
+ Hits 6082 6083 +1
Misses 1840 1840
Partials 399 399
Continue to review full report at Codecov.
|
@andfoy thanks for the PR! FYI we will be removing I'll be sending a follow-up PR removing those |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go, but I'll be removing read_png
and read_jpeg
in a follow-up PR
Should we do something similar for the encode function? Let users to pass a format argument? |
I'm ok for now letting it be explicit via separate functions, otherwise we would need to do some more extra work just before the release (different kwargs for different functions, and kwargs don't work with torchscript). |
I would though consider factoring out the saving part from |
FYI I'm working on implementing a |
pytorch#2760) * Expose image io functions in docs * Expose image funcs in module * Update docstring * Update docstrings for all functions * Update section header
pytorch#2760) * Expose image io functions in docs * Expose image funcs in module * Update docstring * Update docstrings for all functions * Update section header
This PR exposes the main encoding/reading and decoding/writing functions for the image backend:
read_image
decode_image
encode_jpeg
write_jpeg
encode_png
write_png