Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove read_jpeg/read_png in favor of read_image #2764

Merged
merged 1 commit into from
Oct 6, 2020
Merged

Remove read_jpeg/read_png in favor of read_image #2764

merged 1 commit into from
Oct 6, 2020

Conversation

fmassa
Copy link
Member

@fmassa fmassa commented Oct 6, 2020

This way we limit the amount of functions visible to the users.
Users should either call read_image or the individually read_file + decode_*.

@fmassa fmassa requested a review from andfoy October 6, 2020 15:57
andfoy
andfoy approved these changes Oct 6, 2020
View reviewed changes
Copy link
Contributor

@andfoy andfoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fmassa fmassa merged commit 2b2dedc into pytorch:master Oct 6, 2020
@fmassa fmassa deleted the remove-read-png-jpeg branch October 6, 2020 17:37
bryant1410 pushed a commit to bryant1410/vision-1 that referenced this pull request Nov 22, 2020
@fmassa @bryant1410
Remove read_jpeg/read_png in favor of read_image (pytorch#2764)
b2b45fc
vfdev-5 pushed a commit to Quansight/vision that referenced this pull request Dec 4, 2020
@fmassa @vfdev-5
Remove read_jpeg/read_png in favor of read_image (pytorch#2764)
0063b25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andfoy andfoy andfoy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fmassa @andfoy