-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure torchvision operators are added in C++ #2798
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
fb893e7
Ensure torchvision operators are registered in C++ via weak symbols
bmanga eca76e6
Add note to README on how to ensure that torchvision operators are av…
bmanga 535504d
Fix dllimport/dllexport on windows, format files
bmanga 2c3b9d0
Factor out common macros in single file
bmanga f8b3c7d
Expose cuda_version in the API, use it to avoid pruning of ops initia…
bmanga File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
#ifndef TORCHVISION_MACROS_H | ||
#define TORCHVISION_MACROS_H | ||
|
||
#ifdef _WIN32 | ||
#if defined(torchvision_EXPORTS) | ||
#define VISION_API __declspec(dllexport) | ||
#else | ||
#define VISION_API __declspec(dllimport) | ||
#endif | ||
#else | ||
#define VISION_API | ||
#endif | ||
|
||
#if (defined __cpp_inline_variables) || __cplusplus >= 201703L | ||
#define VISION_INLINE_VARIABLE inline | ||
#else | ||
#ifdef _MSC_VER | ||
#define VISION_INLINE_VARIABLE __declspec(selectany) | ||
#else | ||
#define VISION_INLINE_VARIABLE __attribute__((weak)) | ||
#endif | ||
#endif | ||
|
||
#endif // TORCHVISION_MACROS_H |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it will be better to store a reference to the function pointer, rather than doing a full static initializer (which will bang on cuda version even though there's no reason to do so.)