Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Improved test of Resize on PIL images #2874

Merged
merged 1 commit into from
Oct 22, 2020

Conversation

vfdev-5
Copy link
Collaborator

@vfdev-5 vfdev-5 commented Oct 22, 2020

A follow-up PR (#2869) to improve transforms.Resize tests.

  • Replaced random input and configuration by deterministic values

Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

This type of testing would be good to have for Tensor inputs as well. Maybe there is a way to refactor the code in the future so that we don't need to write it twice?

@vfdev-5 vfdev-5 changed the title Improved test of Resize on PIL images [WIP] Improved test of Resize on PIL images Oct 22, 2020
@fmassa fmassa merged commit aa4cf03 into pytorch:master Oct 22, 2020
@vfdev-5 vfdev-5 deleted the vfdev-5/improve-resize-tests branch October 22, 2020 13:38
bryant1410 pushed a commit to bryant1410/vision-1 that referenced this pull request Nov 22, 2020
vfdev-5 added a commit to Quansight/vision that referenced this pull request Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants