PSROIAlign + Dispatcher + Autocast + Code Cleanup #2928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove primitive const declaration from method names. - Using references when possible. - Sync naming of internal methods with other ops.
Codecov Report
@@ Coverage Diff @@
## master #2928 +/- ##
=======================================
Coverage 73.41% 73.41%
=======================================
Files 99 99
Lines 8801 8801
Branches 1389 1389
=======================================
Hits 6461 6461
Misses 1915 1915
Partials 425 425 Continue to review full report at Codecov.
|
datumbox
changed the title
bryant1410
pushed a commit
to bryant1410/vision-1
that referenced
this pull request
Nov 22, 2020
* Fixing types. * Dispatcher + Autocast. * + Autograd. * Clean up and refactor PSROIAlign implementation: - Remove primitive const declaration from method names. - Using references when possible. - Sync naming of internal methods with other ops. * Restoring names of internal methods to avoid conflicts. * Restore include headers.
vfdev-5
pushed a commit
to Quansight/vision
that referenced
this pull request
Dec 4, 2020
* Fixing types. * Dispatcher + Autocast. * + Autograd. * Clean up and refactor PSROIAlign implementation: - Remove primitive const declaration from method names. - Using references when possible. - Sync naming of internal methods with other ops. * Restoring names of internal methods to avoid conflicts. * Restore include headers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #2797 and #2796
Implements Dispatcher + Autocast for PSROIAlign.
I'm also doing some clean up on the original code such as: