Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing C-style typedefs with aliases. #2945

Merged
merged 1 commit into from
Nov 2, 2020

Conversation

datumbox
Copy link
Contributor

@datumbox datumbox commented Nov 1, 2020

Minor refactoring to replace typedefs with C++11 aliases.

@codecov
Copy link

codecov bot commented Nov 1, 2020

Codecov Report

Merging #2945 into master will decrease coverage by 4.62%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2945      +/-   ##
==========================================
- Coverage   73.41%   68.78%   -4.63%     
==========================================
  Files          99       99              
  Lines        8801     8800       -1     
  Branches     1389     1389              
==========================================
- Hits         6461     6053     -408     
- Misses       1915     2318     +403     
- Partials      425      429       +4     
Impacted Files Coverage Δ
torchvision/models/quantization/utils.py 16.00% <0.00%> (-72.00%) ⬇️
torchvision/models/quantization/resnet.py 28.08% <0.00%> (-65.17%) ⬇️
torchvision/datasets/cityscapes.py 20.98% <0.00%> (-59.26%) ⬇️
torchvision/models/quantization/shufflenetv2.py 34.42% <0.00%> (-55.74%) ⬇️
torchvision/models/quantization/mobilenet.py 32.65% <0.00%> (-55.11%) ⬇️
torchvision/io/__init__.py 44.82% <0.00%> (-44.83%) ⬇️
torchvision/models/quantization/googlenet.py 28.08% <0.00%> (-37.08%) ⬇️
torchvision/ops/_register_onnx_ops.py 48.78% <0.00%> (-36.59%) ⬇️
torchvision/models/detection/transform.py 78.33% <0.00%> (-17.23%) ⬇️
torchvision/io/_video_opt.py 23.42% <0.00%> (-17.15%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36daee3...ec76dd4. Read the comment docs.

@datumbox datumbox requested a review from fmassa November 1, 2020 12:41
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fmassa fmassa merged commit 044fcf2 into pytorch:master Nov 2, 2020
@datumbox datumbox deleted the refactor/typedef_to_alias branch November 3, 2020 09:38
bryant1410 pushed a commit to bryant1410/vision-1 that referenced this pull request Nov 22, 2020
vfdev-5 pushed a commit to Quansight/vision that referenced this pull request Dec 4, 2020
@datumbox datumbox mentioned this pull request Jan 5, 2021
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants