Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename InterpolationModes to InterpolationMode #3055

Merged
merged 1 commit into from
Nov 27, 2020
Merged

Rename InterpolationModes to InterpolationMode #3055

merged 1 commit into from
Nov 27, 2020

Conversation

datumbox
Copy link
Contributor

Minor change on names as discussed at #2952

@datumbox datumbox requested review from vfdev-5 and fmassa November 27, 2020 17:04
vfdev-5
vfdev-5 approved these changes Nov 27, 2020
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @datumbox

@datumbox
Copy link
Contributor Author

I know my IDE did an amazing job... :p

@datumbox datumbox merged commit 9e71fda into pytorch:master Nov 27, 2020
@datumbox datumbox deleted the refactoring/rename_enum branch November 27, 2020 18:14
vfdev-5 pushed a commit to Quansight/vision that referenced this pull request Dec 4, 2020
@datumbox @vfdev-5
Plural to singular name change. (pytorch#3055)
3b891df
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

@fmassa fmassa Awaiting requested review from fmassa

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@datumbox @vfdev-5 @facebook-github-bot