Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding invert operator #3065
Adding invert operator #3065
Changes from 1 commit
d9c96e6
f896308
422c9f4
72daf4d
152717f
60fe2cd
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If image dtype is float then max_val will be something very large right ? OK, probably, now I understand the questions asked about float dtype and its range as 0-1.
How about adding an option to the method such that user could specify its own max value. By default can be max dtype...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep you are right. I opted for using the same approach as _bend() to determine the
bound
. I did not optin for passing it as a param to make sure the API is similar as other transformations.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hum, this sounds fishy to me for floating point types. We should probably not be doing
1.79769e+308 - value
for doubles, nor3.40282e+38 - value
for floats.Is there any use-case for applying color transforms to native float images (like satellite or medical data)? If not, we should probably assume that float images are within 0-1 range
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For medical imagery I'd use MONAI as reference and it seems like it is possible: https://docs.monai.io/en/latest/transforms.html#intensity . They do not have any assumptions on the range of input data (uint8 or float).
As for satellite imagery, some intensity manipulations in visible spectrum can be also possible.
I think there are 2 ways possible for this op:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a great reference, thanks @vfdev-5 !
I think that exposing a
min_value / max_value
arguments (which defaults toNone
and has sensible defaults for different data types) is a good trade-off to consider.We can go in two steps though if we want to be extra cautious, and first raise an exception and then in the future add those extra arguments.
Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have decided on getting random apply param with static
get_params()
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've asked @fmassa and he recommended adding it in the
get_params()
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The output of
get_params
should in principle be the parameters we will be using to apply a transformation.In this case, it would be
True / False
for applying the transform or not.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fmassa OK and what to do if there are both to sample: transform random params and random apply one ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a good solution for this one yet. It's a similar story as
ColorAdjust
, and the solutions are not great.We might need to revisit our transforms story, maybe breaking it down into two types of transforms.