PR: Check for FFmpeg header files before adding the video extension #3113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vfdev-5
pushed a commit
to Quansight/vision
that referenced
this pull request
Dec 4, 2020
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 8, 2020
Reviewed By: datumbox Differential Revision: D25396711 fbshipit-source-id: 0430fb1c431634d3bbaef45adf1d9ebfbcc4515e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3101
This error is caused when FFmpeg is installed without its development headers, which is common in most Linux distributions. e.g.,
apt install ffmpegwould installlibavcodec, libavformat, libavutil, ...as opposed tolibavcodec-dev, libavformat-dev, libavutil-dev, .... The current check looks forffmpeg, however this is not sufficient, due to the example posed above.This PR also introduces an additional check on Debian-based installations, where sometimes header files might be included on
/usr/lib/<multiarch-tag>and not in/usr/lib/. See: https://wiki.debian.org/Multiarch/Tuples