Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove torchscript workaround for center_crop #3118

Merged
merged 1 commit into from
Dec 4, 2020
Merged

Remove torchscript workaround for center_crop #3118

merged 1 commit into from
Dec 4, 2020

Conversation

fmassa
Copy link
Member

@fmassa fmassa commented Dec 4, 2020

This has been fixed in PyTorch in pytorch/pytorch#40897

@fmassa fmassa requested review from vfdev-5 and datumbox December 4, 2020 14:23
datumbox
datumbox approved these changes Dec 4, 2020
View reviewed changes
Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

vfdev-5
vfdev-5 approved these changes Dec 4, 2020
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for me too if tests pass :)

@fmassa fmassa merged commit aa75326 into pytorch:master Dec 4, 2020
@fmassa fmassa deleted the remve_center_crop_jit_workaround branch December 4, 2020 15:27
@fmassa fmassa mentioned this pull request Mar 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datumbox datumbox datumbox approved these changes

@vfdev-5 vfdev-5 vfdev-5 approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fmassa @vfdev-5 @datumbox @facebook-github-bot