Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Torch Selective macros in all C++ Ops for better support on mobile #3218

Merged
merged 2 commits into from
Jan 4, 2021

Conversation

datumbox
Copy link
Contributor

@datumbox datumbox commented Jan 4, 2021

  • Added the TORCH_SELECTIVE_NAME and TORCH_SELECTIVE_SCHEMA macros on the op registration.
  • Added the TORCH_FN macro to enable the automatic trade-off between performance vs size.
  • Used full namespaces on method names.

@datumbox datumbox changed the title [WIP] Add Torch Selective macros in all C++ Ops for better support on mobile Add Torch Selective macros in all C++ Ops for better support on mobile Jan 4, 2021
Copy link

@smessmer smessmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks

@datumbox datumbox merged commit 3711754 into pytorch:master Jan 4, 2021
@datumbox datumbox deleted the feature/torch_selective_mobile branch January 4, 2021 18:21
@datumbox datumbox mentioned this pull request Jan 5, 2021
13 tasks
facebook-github-bot pushed a commit that referenced this pull request Jan 21, 2021
#3218)

Summary:
* Adding TORCH_SELECTIVE_* macros on op registration.

* Adding torchvision namespace.

Reviewed By: datumbox

Differential Revision: D25954562

fbshipit-source-id: c0a5fc6394b3e257d0a9879bd08250663abd33c4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants