Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace functional.sigmoid with torch.sigmoid in RPN #3307

Merged
merged 1 commit into from
Jan 27, 2021
Merged

Replace functional.sigmoid with torch.sigmoid in RPN #3307

merged 1 commit into from
Jan 27, 2021

Conversation

fmassa
Copy link
Member

@fmassa fmassa commented Jan 27, 2021

Removes deprecation warning introduced in #3205

/Users/fmassa/anaconda3/lib/python3.6/site-packages/torch/nn/functional.py:1709: UserWarning: nn.functional.sigmoid is deprecated. Use torch.sigmoid instead.

@fmassa fmassa requested a review from datumbox January 27, 2021 09:52
@fmassa fmassa changed the title Replace functional.sigmoid with torch.sigmoid Replace functional.sigmoid with torch.sigmoid in RPN Jan 27, 2021
datumbox
datumbox approved these changes Jan 27, 2021
View reviewed changes
Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fmassa fmassa merged commit cae5400 into pytorch:master Jan 27, 2021
@fmassa fmassa deleted the remove-deprecation-warning branch January 27, 2021 13:09
facebook-github-bot pushed a commit that referenced this pull request Feb 1, 2021
@vincentqb @facebook-github-bot
Replace functional.sigmoid with torch.sigmoid (#3307)
dfab2df 
Summary: Removes deprecation warning

Reviewed By: datumbox

Differential Revision: D26156378

fbshipit-source-id: 796fce9c05fa3818c26e9ba2ba0cbab7085c9d1a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datumbox datumbox datumbox approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fmassa @datumbox @facebook-github-bot