Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move run-clang-format script in .circleci #3329

Merged
merged 1 commit into from
Feb 1, 2021

Conversation

datumbox
Copy link
Contributor

Travis CI has been deprecated, so there is no reason to keep a top-level folder in our repo with a single script. I'm moving the clang format script inside .circleci and I put its license on the top of the file.

@datumbox datumbox requested a review from fmassa January 30, 2021 16:11
@datumbox datumbox closed this Jan 30, 2021
@datumbox datumbox deleted the ci/move_clangscript branch January 30, 2021 16:14
@datumbox datumbox restored the ci/move_clangscript branch January 30, 2021 16:14
@datumbox datumbox reopened this Jan 30, 2021
@codecov
Copy link

codecov bot commented Jan 30, 2021

Codecov Report

Merging #3329 (8595541) into master (09ce675) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3329   +/-   ##
=======================================
  Coverage   73.96%   73.96%           
=======================================
  Files         104      104           
  Lines        9607     9607           
  Branches     1537     1537           
=======================================
  Hits         7106     7106           
  Misses       2024     2024           
  Partials      477      477           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09ce675...8595541. Read the comment docs.

Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was precisely thinking about that the other day, thanks for doing this!

@fmassa fmassa merged commit 1e3a183 into pytorch:master Feb 1, 2021
@datumbox datumbox deleted the ci/move_clangscript branch February 1, 2021 10:20
facebook-github-bot pushed a commit that referenced this pull request Feb 4, 2021
Reviewed By: datumbox

Differential Revision: D26226615

fbshipit-source-id: 4e4130edcb6fb89c72d474da5d621fd6b1299f78
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants