Add download tests for remaining datasets #3338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
pmeier
force-pushed
the
download-tests-kmnist
branch
from
5b8c3a6 to
c8f54c4
Compare
pmeier
changed the title
|
The three failing URLs
are working fine. Either re-run the download tests or accept them as fluke an merge this 😉 |
|
@pmeier There are still a few failures. I think it's important to see them passing and address any flakiness before merging. Let me know what you think. |
|
@datumbox The failing URLs reported in the test are the ones from my last comment; they are working. IMO this was just a fluke. Lets see what the new CI run brings. |
|
So, I was wrong. The request indeed timed out. I've added some logic to better capture timeouts. As for the reason why these tests times out: I'm not sure yet. I cannot produce the timeout locally. |
…load-tests-kmnist
datumbox
approved these changes
Feb 3, 2021
| except HTTPError as error: | ||
| raise AssertionError(f"The server returned {error.code}: {error.reason}.") from error | ||
|
|
||
|
|
||
| def assert_url_is_accessible(url): | ||
| request = Request(url, headers=dict(method="HEAD")) | ||
| with assert_server_response_ok(): | ||
| urlopen(request) | ||
| urlopen(request, timeout=5.0) |
There was a problem hiding this comment.
Nit: Replace hardcode numeric values with a constant.
|
|
||
|
|
||
| def assert_file_downloads_correctly(url, md5): | ||
| with get_tmp_dir() as root: | ||
| file = path.join(root, path.basename(url)) | ||
| with assert_server_response_ok(): | ||
| with urlopen(url) as response, open(file, "wb") as fh: | ||
| with urlopen(url, timeout=5.0) as response, open(file, "wb") as fh: |
Merged
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 4, 2021
Summary: * kmnist * emnist * qmnist * omniglot * phototour * sbdataset * sbu * semeion * stl10 * svhn * usps * cifar100 * enable download logging for google drive * celeba * widerface * lint * add timeout logic * lint * debug CI connection to problematic server * set timeout for ping * [ci skip] remove ping * revert debugging * disable requests to problematic server * re-enable all other tests Reviewed By: datumbox Differential Revision: D26226602 fbshipit-source-id: f2e961205f6dc20fe87c91b2d3a6c07fbad3bf8e Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the remaining download tests for
KMNISTEMNISTQMNISTOmniglotPhototourSBDatasetSBUSEMEIONSTL10SVHNUSPSCelebAWIDERFaceand fixes the test for
CIFAR100.