Add tests for UCF101 #3411
Merged
Add tests for UCF101 #3411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Codecov Report
@@ Coverage Diff @@
## master #3411 +/- ##
==========================================
- Coverage 76.01% 75.12% -0.89%
==========================================
Files 105 105
Lines 9697 9722 +25
Branches 1556 1563 +7
==========================================
- Hits 7371 7304 -67
- Misses 1839 1932 +93
+ Partials 487 486 -1
Continue to review full report at Codecov.
|
fmassa
approved these changes
Feb 23, 2021
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 4, 2021
Summary: * enable default frames per clips for video test cases * add tests for UCF101 * remove old tests as well as fake data generation * better explain frames_per_clip overriding * lint Reviewed By: fmassa Differential Revision: D26756269 fbshipit-source-id: c3a6ae69a0e3155864bd3d09556a99f7f6771953 Co-authored-by: Francisco Massa <fvsmassa@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes use of the added dataset test case base class and supersedes older tests for UCF101. Since we now work with much (spatially) smaller videos, this significantly reduces the wall time.
In addition, this adds the capability to leave out the
frames_per_clipargument, which is required in every video dataset. If no value is returned byinject_fake_data()we simply add1as default. With this we have a 1-to-1 correspondence oflen(dataset)to videos generated bycreate_video_folder(). Since all video datasets use aVideoClipsobject internally that handles the clip generation, we don't need to test that here.