improve Coco(Captions|Detection) implementation #3417
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CocoCaptions
is a special case ofCocoDetection
. WhileCocoDetection
returns the complete annotation dictionary,CocoCaptions
extracts the captions out of them. Thus, both implementations are functionally identical except forvision/torchvision/datasets/coco.py
Line 74 in 22c548b
To make this easier to maintain, this lets
CocoCaptions
inherit fromCocoDetection
and only overwrites the annotation loading.Blocked by #3416 to ensure the same functionality.