-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.circleci: Downgrade CUDA 11.2 -> 11.1 #3418
Conversation
f94038b
to
13d3379
Compare
There were performance issues with 11.2 so we're opting to build packages for 11.1 instead Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
13d3379
to
069c0e4
Compare
Looks like we're experiencing failures on windows builds: For wheels (CircleCI logs):
CC @peterjc123 @nbcsm @guyang3532 @maxluk @gunandrose4u @smartcat2010 @mszhanyi For conda (CircleCI logs)
|
Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
pytorch/pytorch#52503 should fix this. |
@fmassa @seemethere Do we need to fix the cmake scripts as well? cc @janeyx99 |
I had merged pytorch/pytorch#52305 intending to introduce a dummy torch_cuda when we split the library, which might resolve these downstream dependencies. However, it's not cherrypicked into the release cut :/ so it probably would be best to go with your fixes here @peterjc123 |
This pull request has been merged in 44ff79d. |
What? I didn't merge this @facebook-github-bot 😞 |
Summary: Fixes pytorch/vision#3418 (comment) Pull Request resolved: pytorch#52503 Reviewed By: malfet Differential Revision: D26546857 Pulled By: janeyx99 fbshipit-source-id: a100b408e7cd28695145a1dda7f2fa081bb7f21f (cherry picked from commit 44ff79d) Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
Codecov Report
@@ Coverage Diff @@
## master #3418 +/- ##
==========================================
- Coverage 76.01% 75.13% -0.88%
==========================================
Files 105 105
Lines 9697 9722 +25
Branches 1556 1563 +7
==========================================
- Hits 7371 7305 -66
- Misses 1839 1930 +91
Partials 487 487
Continue to review full report at Codecov.
|
Reviewed By: NicolasHug Differential Revision: D26605322 fbshipit-source-id: 1dfe157d2094c1186c74b22eb1184d7fa498cc3f
Summary: Fixes pytorch/vision#3418 (comment) Pull Request resolved: pytorch#52503 Reviewed By: malfet Differential Revision: D26546857 Pulled By: janeyx99 fbshipit-source-id: a100b408e7cd28695145a1dda7f2fa081bb7f21f
Summary: Fixes pytorch/vision#3418 (comment) Pull Request resolved: pytorch#52503 Reviewed By: malfet Differential Revision: D26546857 Pulled By: janeyx99 fbshipit-source-id: a100b408e7cd28695145a1dda7f2fa081bb7f21f
There were performance issues with 11.2 so we're opting to build
packages for 11.1 instead
Follow up to #3341
Relates to pytorch/pytorch#52151
Signed-off-by: Eli Uriegas eliuriegas@fb.com