Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.circleci: Downgrade CUDA 11.2 -> 11.1 #3418

Merged
merged 4 commits into from
Feb 22, 2021

Conversation

seemethere
Copy link
Member

@seemethere seemethere commented Feb 18, 2021

There were performance issues with 11.2 so we're opting to build
packages for 11.1 instead

Follow up to #3341

Relates to pytorch/pytorch#52151

Signed-off-by: Eli Uriegas eliuriegas@fb.com

There were performance issues with 11.2 so we're opting to build
packages for 11.1 instead

Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
@seemethere
Copy link
Member Author

seemethere commented Feb 18, 2021

Looks like we're experiencing failures on windows builds:

For wheels (CircleCI logs):

deform_conv2d_kernel.obj : error LNK2001: unresolved external symbol "__declspec(dllimport) struct cudaDeviceProp * __cdecl at::cuda::getCurrentDeviceProperties(void)" (__imp_?getCurrentDeviceProperties@cuda@at@@YAPEAUcudaDeviceProp@@XZ)
build\lib.win-amd64-3.9\torchvision\_C.pyd : fatal error LNK1120: 1 unresolved externals

CC @peterjc123 @nbcsm @guyang3532 @maxluk @gunandrose4u @smartcat2010 @mszhanyi

For conda (CircleCI logs)

   Creating library C:\tools\MINICO~1\CONDA-~2\TORCHV~1\work\build\temp.win-amd64-3.9\Release\tools\MINICO~1\CONDA-~2\TORCHV~1\work\torchvision\csrc\ops\autocast\_C.lib and object C:\tools\MINICO~1\CONDA-~2\TORCHV~1\work\build\temp.win-amd64-3.9\Release\tools\MINICO~1\CONDA-~2\TORCHV~1\work\torchvision\csrc\ops\autocast\_C.exp
deform_conv2d_kernel.obj : error LNK2001: unresolved external symbol "__declspec(dllimport) struct cudaDeviceProp * __cdecl at::cuda::getCurrentDeviceProperties(void)" (__imp_?getCurrentDeviceProperties@cuda@at@@YAPEAUcudaDeviceProp@@XZ)
build\lib.win-amd64-3.9\torchvision\_C.pyd : fatal error LNK1120: 1 unresolved externals

Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
@peterjc123
Copy link
Contributor

pytorch/pytorch#52503 should fix this.

@peterjc123
Copy link
Contributor

peterjc123 commented Feb 19, 2021

@fmassa @seemethere Do we need to fix the cmake scripts as well? cc @janeyx99
Fix: #3419

@janeyx99
Copy link
Contributor

I had merged pytorch/pytorch#52305 intending to introduce a dummy torch_cuda when we split the library, which might resolve these downstream dependencies. However, it's not cherrypicked into the release cut :/ so it probably would be best to go with your fixes here @peterjc123

@facebook-github-bot
Copy link

This pull request has been merged in 44ff79d.

@seemethere
Copy link
Member Author

What? I didn't merge this @facebook-github-bot 😞

@seemethere seemethere reopened this Feb 19, 2021
seemethere pushed a commit to seemethere/pytorch that referenced this pull request Feb 19, 2021
Summary:
Fixes pytorch/vision#3418 (comment)

Pull Request resolved: pytorch#52503

Reviewed By: malfet

Differential Revision: D26546857

Pulled By: janeyx99

fbshipit-source-id: a100b408e7cd28695145a1dda7f2fa081bb7f21f
(cherry picked from commit 44ff79d)
Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
@seemethere seemethere requested a review from malfet February 19, 2021 23:42
@seemethere seemethere removed the Merged label Feb 19, 2021
@codecov
Copy link

codecov bot commented Feb 22, 2021

Codecov Report

Merging #3418 (9706b3f) into master (433283e) will decrease coverage by 0.87%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3418      +/-   ##
==========================================
- Coverage   76.01%   75.13%   -0.88%     
==========================================
  Files         105      105              
  Lines        9697     9722      +25     
  Branches     1556     1563       +7     
==========================================
- Hits         7371     7305      -66     
- Misses       1839     1930      +91     
  Partials      487      487              
Impacted Files Coverage Δ
torchvision/datasets/voc.py 50.49% <0.00%> (-41.82%) ⬇️
torchvision/datasets/caltech.py 42.52% <0.00%> (-36.79%) ⬇️
torchvision/datasets/coco.py 30.95% <0.00%> (-15.48%) ⬇️
torchvision/datasets/vision.py 65.51% <0.00%> (-3.45%) ⬇️
torchvision/ops/boxes.py 87.77% <0.00%> (ø)
torchvision/ops/roi_pool.py 75.00% <0.00%> (ø)
torchvision/ops/roi_align.py 70.96% <0.00%> (ø)
torchvision/ops/ps_roi_pool.py 74.07% <0.00%> (ø)
torchvision/ops/ps_roi_align.py 72.41% <0.00%> (ø)
torchvision/datasets/sbd.py 34.42% <0.00%> (+1.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 433283e...61c6fdc. Read the comment docs.

@seemethere seemethere merged commit 0e32a12 into pytorch:master Feb 22, 2021
@seemethere seemethere deleted the downgrade_cu111 branch February 22, 2021 16:49
facebook-github-bot pushed a commit that referenced this pull request Feb 23, 2021
Reviewed By: NicolasHug

Differential Revision: D26605322

fbshipit-source-id: 1dfe157d2094c1186c74b22eb1184d7fa498cc3f
iramazanli pushed a commit to iramazanli/pytorch that referenced this pull request Feb 23, 2021
Summary:
Fixes pytorch/vision#3418 (comment)

Pull Request resolved: pytorch#52503

Reviewed By: malfet

Differential Revision: D26546857

Pulled By: janeyx99

fbshipit-source-id: a100b408e7cd28695145a1dda7f2fa081bb7f21f
aocsa pushed a commit to Quansight/pytorch that referenced this pull request Mar 15, 2021
Summary:
Fixes pytorch/vision#3418 (comment)

Pull Request resolved: pytorch#52503

Reviewed By: malfet

Differential Revision: D26546857

Pulled By: janeyx99

fbshipit-source-id: a100b408e7cd28695145a1dda7f2fa081bb7f21f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants