Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove old CIFAR tests and fake data generation #3447

Merged
merged 3 commits into from
Mar 1, 2021

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Feb 24, 2021

#3402 added tests for CIFAR100? in the new architecture, but forgot to remove the old ones.

@codecov
Copy link

codecov bot commented Feb 24, 2021

Codecov Report

Merging #3447 (fd2bbe0) into master (b266c2f) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3447      +/-   ##
==========================================
- Coverage   76.13%   76.07%   -0.06%     
==========================================
  Files         105      105              
  Lines        9703     9697       -6     
  Branches     1556     1556              
==========================================
- Hits         7387     7377      -10     
- Misses       1836     1840       +4     
  Partials      480      480              
Impacted Files Coverage Δ
torchvision/datasets/cifar.py 90.00% <0.00%> (-5.00%) ⬇️
torchvision/transforms/_transforms_video.py 88.88% <0.00%> (-0.35%) ⬇️
torchvision/models/mobilenetv2.py 86.95% <0.00%> (-0.28%) ⬇️
torchvision/transforms/_functional_video.py 95.23% <0.00%> (-0.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5266a72...540b157. Read the comment docs.

Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fmassa fmassa merged commit a7a2ee7 into pytorch:master Mar 1, 2021
@pmeier pmeier deleted the remove-old-cifar-tests branch March 1, 2021 11:15
facebook-github-bot pushed a commit that referenced this pull request Mar 4, 2021
Reviewed By: fmassa

Differential Revision: D26756258

fbshipit-source-id: eaf36956b2f341276088ed7702a484a9b93d448e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants