Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tests for SBU dataset #3464

Merged
merged 3 commits into from
Mar 1, 2021
Merged

add tests for SBU dataset #3464

merged 3 commits into from
Mar 1, 2021

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Feb 26, 2021

No description provided.

@pmeier pmeier mentioned this pull request Feb 26, 2021
Closed
@codecov
Copy link

codecov bot commented Feb 26, 2021 •
edited
Loading

Codecov Report

Merging #3464 (a40d5ed) into master (b266c2f) will increase coverage by 0.28%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3464      +/-   ##
==========================================
+ Coverage   76.13%   76.41%   +0.28%     
==========================================
  Files         105      105              
  Lines        9703     9703              
  Branches     1556     1556              
==========================================
+ Hits         7387     7415      +28     
+ Misses       1836     1806      -30     
- Partials      480      482       +2
Impacted Files Coverage Δ
torchvision/datasets/sbu.py 71.18% <0.00%> (+47.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e20b9d...0962ec8. Read the comment docs.

datumbox
datumbox approved these changes Feb 28, 2021
View reviewed changes
Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fmassa fmassa merged commit b5f29cc into pytorch:master Mar 1, 2021
@pmeier pmeier deleted the tests-sbu branch March 1, 2021 12:56
facebook-github-bot pushed a commit that referenced this pull request Mar 4, 2021
@zhangguanheng66 @facebook-github-bot
add tests for SBU dataset (#3464)
9067df1 
Summary: Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>

Reviewed By: fmassa

Differential Revision: D26756256

fbshipit-source-id: dd51a6882d37eef7ab9b7db927893b45188bd197
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmassa fmassa fmassa approved these changes

@datumbox datumbox datumbox approved these changes

Assignees
No one assigned
Labels
cla signed enhancement module: datasets module: tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pmeier @datumbox @fmassa @NicolasHug @facebook-github-bot