Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase tolerance in scripted models #3479

Merged
merged 2 commits into from
Mar 1, 2021
Merged

Increase tolerance in scripted models #3479

merged 2 commits into from
Mar 1, 2021

Conversation

fmassa
Copy link
Member

@fmassa fmassa commented Mar 1, 2021

Fixes #3475

datumbox
datumbox approved these changes Mar 1, 2021
View reviewed changes
Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Mar 1, 2021 •
edited
Loading

Codecov Report

Merging #3479 (7fe05e2) into master (47d76bb) will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3479      +/-   ##
==========================================
+ Coverage   77.97%   78.09%   +0.12%     
==========================================
  Files         105      105              
  Lines        9707     9707              
  Branches     1556     1556              
==========================================
+ Hits         7569     7581      +12     
+ Misses       1647     1637      -10     
+ Partials      491      489       -2
Impacted Files Coverage Δ
torchvision/transforms/functional_tensor.py 79.23% <0.00%> (+0.19%) ⬆️
torchvision/models/detection/anchor_utils.py 94.66% <0.00%> (+1.33%) ⬆️
torchvision/ops/deform_conv.py 72.30% <0.00%> (+3.07%) ⬆️
torchvision/extension.py 67.21% <0.00%> (+13.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47d76bb...7fe05e2. Read the comment docs.

@fmassa fmassa merged commit 0ec5f31 into pytorch:master Mar 1, 2021
@fmassa fmassa deleted the bump-tol branch March 1, 2021 15:14
facebook-github-bot pushed a commit that referenced this pull request Mar 4, 2021
@zhangguanheng66 @facebook-github-bot
Increase tolerance in scripted models (#3479)
31baa4a 
Reviewed By: fmassa

Differential Revision: D26756264

fbshipit-source-id: d9667961b4a4f6e02c7be6d571804b51f297b6de
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datumbox datumbox datumbox approved these changes

Assignees
No one assigned
Labels
cla signed module: tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test_maskrcnn_resnet50_fpn_cuda is failing with precision issues
4 participants
@fmassa @datumbox @NicolasHug @facebook-github-bot