-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove imprecise error handling in PhotoTour dataset #3488
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3488 +/- ##
==========================================
- Coverage 79.26% 78.70% -0.56%
==========================================
Files 105 105
Lines 9742 9708 -34
Branches 1564 1555 -9
==========================================
- Hits 7722 7641 -81
- Misses 1533 1576 +43
- Partials 487 491 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Summary: Co-authored-by: Francisco Massa <fvsmassa@gmail.com> Reviewed By: fmassa Differential Revision: D27127993 fbshipit-source-id: fea968bbea5f305e4d69aacbdd0b9d528950666d
Addresses #3448 (comment).
.cache()
will raise aFileNotFoundError
and thus there is no need to process this in any way.