Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove imprecise error handling in PhotoTour dataset #3488

Merged
merged 5 commits into from
Mar 11, 2021

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Mar 2, 2021

Addresses #3448 (comment). .cache() will raise a FileNotFoundError and thus there is no need to process this in any way.

@codecov
Copy link

codecov bot commented Mar 2, 2021

Codecov Report

Merging #3488 (4248584) into master (7992eb5) will decrease coverage by 0.55%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3488      +/-   ##
==========================================
- Coverage   79.26%   78.70%   -0.56%     
==========================================
  Files         105      105              
  Lines        9742     9708      -34     
  Branches     1564     1555       -9     
==========================================
- Hits         7722     7641      -81     
- Misses       1533     1576      +43     
- Partials      487      491       +4     
Impacted Files Coverage Δ
torchvision/datasets/phototour.py 81.63% <100.00%> (-0.55%) ⬇️
torchvision/datasets/flickr.py 25.64% <0.00%> (-73.08%) ⬇️
torchvision/ops/boxes.py 87.77% <0.00%> (-3.49%) ⬇️
torchvision/transforms/functional_tensor.py 79.19% <0.00%> (-0.66%) ⬇️
torchvision/models/detection/_utils.py 82.58% <0.00%> (-0.53%) ⬇️
torchvision/transforms/functional_pil.py 67.61% <0.00%> (-0.52%) ⬇️
torchvision/transforms/autoaugment.py 94.04% <0.00%> (-0.08%) ⬇️
torchvision/transforms/transforms.py 84.28% <0.00%> (-0.03%) ⬇️
torchvision/transforms/functional.py 81.77% <0.00%> (ø)
torchvision/datasets/utils.py 72.58% <0.00%> (+2.37%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7992eb5...ab7d55b. Read the comment docs.

Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fmassa fmassa merged commit 6f062c9 into pytorch:master Mar 11, 2021
@pmeier pmeier deleted the phototour-nit branch March 12, 2021 06:45
facebook-github-bot pushed a commit that referenced this pull request Mar 18, 2021
Summary: Co-authored-by: Francisco Massa <fvsmassa@gmail.com>

Reviewed By: fmassa

Differential Revision: D27127993

fbshipit-source-id: fea968bbea5f305e4d69aacbdd0b9d528950666d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants