fix test_extract_(zip|tar|tar_xz|gzip) on windows #3542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 18, 2021
Summary: * fix test_extract_(zip|tar|tar_xz|gzip) on windows * lint Reviewed By: fmassa Differential Revision: D27127988 fbshipit-source-id: 62394146aef72ca5baf86ae86d52cf82f77c07aa Co-authored-by: Francisco Massa <fvsmassa@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests were disabled before, because they would fail on Windows due to this construct
vision/test/test_datasets_utils.py
Lines 108 to 110 in 3428a7d
On Windows this raised a
PermissionsErrorbecausezipfile.ZipFiletried to open an already open file. You can find a similar construct in all the disabled tests.Given that all this already happens in a temporary directory that will be deleted after the test is complete, it is unnecessarily complicated to also create the names of the files at random. This PR fixes this which makes the tests more legible as well as able to run on Windows.