Fix redirect behavior of datasets.utils.download_url #3564
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3560. #3236 introduced redirect resolving in
datasets.utils.download_url()
. For thisrequests.get()
is used:vision/torchvision/datasets/utils.py
Lines 64 to 75 in c808d16
This has two downsides:
requests.get()
already downloads the data although we only want to check if a redirect happens. Meaning, we download the data twice. This never stood out in our tests, since we download a small amount of data which leads to a minimal increase in testing time. For large datasets, saySTL10
STL10 does not download #3560, this is not acceptable. We should switch to a head requests, e.g.requests.head()
, that also carries the redirect information without downloading any data.download
flag is now indirectly dependent onrequests
without any mention of this in the documentation.This PR solves both.