Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed floor_divide deprecation warnings seen in pytest output #3672

Merged
merged 4 commits into from
Apr 16, 2021
Merged

Fixed floor_divide deprecation warnings seen in pytest output #3672

merged 4 commits into from
Apr 16, 2021

Conversation

prabhat00155
Copy link
Contributor

Addresses #3668

@prabhat00155
Fixed floor_divide deprecation warnings given by ====================…
ca288ef 
…========= test session starts ==============================

platform darwin -- Python 3.7.5, pytest-6.2.2, py-1.10.0, pluggy-0.13.1
rootdir: /Users/prabhatroy/Documents/pytorch/repos/vision
collected 0 items

============================ no tests ran in 0.00s =============================
NicolasHug
NicolasHug reviewed Apr 15, 2021
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @prabhat00155 , looking at the logs it seems that there's still one warning showing: test/test_datasets.py::CelebATestCase::test_attr_names

torchvision/models/detection/roi_heads.py Outdated Show resolved Hide resolved
@prabhat00155
Copy link
Contributor Author

prabhat00155 commented Apr 15, 2021 •
edited
Loading

Thanks @prabhat00155 , looking at the logs it seems that there's still one warning showing: test/test_datasets.py::CelebATestCase::test_attr_names

Thanks @NicolasHug, I didn't see this warning locally, perhaps the test got skipped.

@prabhat00155 prabhat00155 changed the title Fixed floor_divide deprecation warnings given by pytest test_models.py Fixed floor_divide deprecation warnings seen in pytest output Apr 15, 2021
@prabhat00155 prabhat00155 requested a review from NicolasHug April 16, 2021 11:33
NicolasHug
NicolasHug approved these changes Apr 16, 2021
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@NicolasHug NicolasHug merged commit 9778d26 into pytorch:master Apr 16, 2021
@prabhat00155 prabhat00155 deleted the prabhat00155/fix_warnings branch April 16, 2021 13:49
@prabhat00155 prabhat00155 restored the prabhat00155/fix_warnings branch April 19, 2021 16:48
@prabhat00155 prabhat00155 deleted the prabhat00155/fix_warnings branch April 19, 2021 17:03
facebook-github-bot pushed a commit that referenced this pull request May 4, 2021
@cpuhrsch @facebook-github-bot
[fbsync] Fixed floor_divide deprecation warnings seen in pytest output (
06e7b91 
#3672)

Reviewed By: NicolasHug

Differential Revision: D28169157

fbshipit-source-id: a6849e893c9b7c8ad684c77b5813584f8de1ddec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasHug NicolasHug NicolasHug approved these changes

Assignees
No one assigned
Labels
cla signed code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prabhat00155 @NicolasHug @facebook-github-bot