[android][circle_ci] android build and nightly publish jobs #3679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanKobzarev
force-pushed
the
android_circleci_2
branch
from
7b4ea9e to
5ca4cb2
Compare
fmassa
approved these changes
May 5, 2021
There was a problem hiding this comment.
This looks great, thanks a lot for the PR @IvanKobzarev !
I have one question regarding versioning, otherwise the PR is good to merge.
| implementation 'org.pytorch:pytorch_android:1.8.0-SNAPSHOT' | ||
| implementation 'org.pytorch:pytorch_android_torchvision:1.8.0-SNAPSHOT' | ||
| implementation "org.pytorch:pytorch_android:$pytorchAndroidVersion" | ||
| implementation "org.pytorch:pytorch_android_torchvision:$pytorchAndroidVersion" |
There was a problem hiding this comment.
I think we should discuss if we would want torchvision android artifacts to be versioned with the same version as PyTorch or with the version of torchvision (which is different than Pytorch versions).
In one hand, having the same version as PyTorch makes it easier for matching dependencies, on the other hand there are discrepancies wrt what we ship in the Python side. Thoughts?
|
Let's get this merged to unblock, and then maybe revisit the versioning in a follow-up PR |
facebook-github-bot
pushed a commit
that referenced
this pull request
May 17, 2021
Summary: Co-authored-by: Francisco Massa <fvsmassa@gmail.com> Reviewed By: datumbox Differential Revision: D28473323 fbshipit-source-id: 92bb8e34aeedf705f6217bd467c84b27e89145bc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing 2 additional jobs:
binary_libtorchvision_ops_android - building torchvision_ops for android on every PR
nightly-binary-libtorchvision_ops-android-upload - publish nightlies to sonatype
Both jobs use docker image circleci/android:api-29-ndk with preinstalled android sdk/ndk.
Installing gradle from pytorch aws (just unpacking)
Jobs with default resources failed, so changed:
gradle jvm args: org.gradle.jvmargs=-Xmx12g
resource_class: xlarge