Cleaned-up imports in test files related to datasets #3720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasHug
approved these changes
Apr 26, 2021
There was a problem hiding this comment.
Thanks @prabhat00155 ,
In general I'm not too keen on re-ordering imports, as it breaks git blame for little benefits. Maybe others have different opinions (@fmassa @datumbox)?
I'll approve anyway as the removal of HAS_PYAV and others unused imports is good!
(Also: merge conflicts ;) )
|
No strong opinions from my side on the order of the imports. As a general "policy", as Nicolas said, we do try to avoid rewriting git-blame when possible. Having said that, I'm guilty of rewriting the history of large parts to refactor, so I can't cast the first stone. 😄 |
|
Makes sense. I was trying to clean up unused imports and while I was at it, made it pep8 compliant as well. |
pmeier
reviewed
Apr 26, 2021
facebook-github-bot
pushed a commit
that referenced
this pull request
May 4, 2021
Reviewed By: NicolasHug Differential Revision: D28169154 fbshipit-source-id: 1eeb916675849d98cefa7ff52d99798c520efa64
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.